fix: Elastic col width must be at least the length of its name - #13
Merged
Conversation
tycho-casap
approved these changes
Jul 15, 2026
tycho-casap
left a comment
tycho-casap
left a comment
There was a problem hiding this comment.
test definitely needs to be gofmt'd
tychoish
pushed a commit
that referenced
this pull request
Jul 16, 2026
Fixes a bug whereby `BuildMaxWidth()` would panic [here](https://github.com/tychoish/fun/blob/main/mdwn/table.go#L229) because the computed width of the elastic column ([here](https://github.com/tychoish/fun/blob/main/mdwn/table.go#L193)) was less than the length of the column's title: ``` panic: strings: negative Repeat count ``` This change ensures the width of the elastic column is at least the length of the column's name
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a bug whereby
BuildMaxWidth()would panic here because the computed width of the elastic column (here) was less than the length of the column's title:This change ensures the width of the elastic column is at least the length of the column's name